Fix multiple ggplotly() regressions #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
fix-ggplotly-regressions
branch
2 times, most recently
from
8b444fc to
effb698
Compare
cpsievert
commented
Jan 19, 2026
inst/examples/shiny/event_data/tests/testthat/_snaps/shinytest2/004.json
Show resolved
Hide resolved
cpsievert
commented
Jan 19, 2026
inst/examples/shiny/event_data/tests/testthat/_snaps/shinytest2/003.json
Show resolved
Hide resolved
cpsievert
commented
Jan 19, 2026
inst/examples/shiny/event_data/tests/testthat/_snaps/shinytest2/002.json
Show resolved
Hide resolved
cpsievert
force-pushed
the
fix-ggplotly-regressions
branch
from
35e5d61 to
ba1e009
Compare
cpsievert
force-pushed
the
fix-ggplotly-regressions
branch
from
79b5663 to
1be6096
Compare
The linewidth_or_size.element fix now correctly returns "linewidth" for S7 objects (ggplot2 >= 4.0), which means theme elements like tickwidth, gridwidth, and borderwidth now get their actual values instead of 0. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 7 ggplotly() bugs, primarily related to legend handling, theme translation, and tooltip generation:
ggplot()does not display aesthetic in tooltip when aesthetic name == 'group' #2415: Variable named 'group' now shown in tooltip when mapped to aesthetic (e.g.,colour = group)element_blankpanel.border no longer creates empty shapes (ggplot2 4.0.0 compatibility)scale_*_manualwith unused aesthetics no longer errors (e.g.,aesthetics = c("colour", "fill")when only colour is used)geom_boxplot(outlier.shape = NA)now hides outlier pointslegend.positiontheme element now translated to plotly layout (bottom, top, left, inside/numeric)geom_blank()no longer drops legend for other geoms in the same plotCloses #2415
Closes #2455
Closes #2460
Closes #2466
Closes #2305
Closes #2467
Closes #2407
Closes #2187
Closes #2281
Test plan
🤖 Generated with Claude Code